]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
keyboard: Replace `oskCompletion` setter with public method
authorSundeep Mediratta <smedius@gmail.com>
Thu, 15 Aug 2024 20:18:39 +0000 (16:18 -0400)
committerFlorian Müllner <fmuellner@gnome.org>
Thu, 5 Sep 2024 11:09:38 +0000 (13:09 +0200)
The underlying value only changes asynchronously, which makes a
setter a bit awkward, so replace it with a public async function.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3439>

js/ui/keyboard.js

index 908655951484072ed1550141fece9866a853a5d4..a8b90caa26d007481f01dfc6ac0fd90de51960cd 100644 (file)
@@ -1259,7 +1259,7 @@ export const Keyboard = GObject.registerClass({
 
         this._clearShowIdle();
 
-        this._keyboardController.oskCompletion = false;
+        this._keyboardController.setOskCompletion(false);
         this._keyboardController.destroy();
 
         Main.layoutManager.untrackChrome(this);
@@ -1723,7 +1723,7 @@ export const Keyboard = GObject.registerClass({
             return;
         }
 
-        this._keyboardController.oskCompletion = true;
+        this._keyboardController.setOskCompletion(true);
         this._clearKeyboardRestTimer();
 
         if (immediate) {
@@ -1758,7 +1758,7 @@ export const Keyboard = GObject.registerClass({
         if (!this._keyboardVisible)
             return;
 
-        this._keyboardController.oskCompletion = false;
+        this._keyboardController.setOskCompletion(false);
         this._clearKeyboardRestTimer();
 
         if (immediate) {
@@ -2105,7 +2105,7 @@ class KeyboardController extends Signals.EventEmitter {
         Main.inputMethod.commit(str);
     }
 
-    async _setOskCompletion(enabled) {
+    async setOskCompletion(enabled) {
         if (this._oskCompletionEnabled === enabled)
             return;
 
@@ -2115,10 +2115,6 @@ class KeyboardController extends Signals.EventEmitter {
         Main.inputMethod.update();
     }
 
-    set oskCompletion(enabled) {
-        this._setOskCompletion(enabled);
-    }
-
     keyvalPress(keyval) {
         this._virtualDevice.notify_keyval(Clutter.get_current_event_time() * 1000,
             keyval, Clutter.KeyState.PRESSED);